Skip to content

[INSTALL] Fix cmake/opentelemetry-cpp-config.cmake.in #3165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 24, 2024
Merged

[INSTALL] Fix cmake/opentelemetry-cpp-config.cmake.in #3165

merged 2 commits into from
Nov 24, 2024

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Nov 23, 2024 •
edited
Loading

Fixes # (issue)

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@netlify Netlify
Copy link

netlify bot commented Nov 23, 2024 •
edited
Loading

✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 5fbc927
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/674212681196940008d0bc57

@marcalff
Copy link
Member Author

@owent Please review.

@marcalff marcalff marked this pull request as ready for review November 23, 2024 17:35
@marcalff marcalff requested a review from a team as a code owner November 23, 2024 17:35
This was referenced Nov 23, 2024
Merged
Closed
@marcalff marcalff added pr:please-review This PR is ready for review issue:blocking This issue is preventing other fixes labels Nov 23, 2024
@marcalff
Copy link
Member Author

This is a regression, blocking the 1.18.0 release.

@codecov Codecov
Copy link

codecov bot commented Nov 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.86%. Comparing base (9d998e3) to head (5fbc927).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3165   +/-   ##
=======================================
  Coverage   87.86%   87.86%           
=======================================
  Files         195      195           
  Lines        6151     6151           
=======================================
  Hits         5404     5404           
  Misses        747      747
---- 🚨 Try these New Features:

owent
owent approved these changes Nov 24, 2024
View reviewed changes
Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@marcalff marcalff removed the issue:blocking This issue is preventing other fixes label Nov 24, 2024
@marcalff marcalff merged commit fcdd526 into open-telemetry:main Nov 24, 2024
57 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Nov 26, 2024
Merged
@marcalff marcalff deleted the fix_cmake_install branch February 5, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@owent owent owent approved these changes

Assignees

No one assigned

Labels

pr:please-review This PR is ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marcalff @owent